Request for changes-119: Install ossimPlugins headers related to ossimSarSensorModel

Status

• Author: Julien Michel (CNES)
• Submitted on 25.10.2017
• Proposed target release: 6.4
• Adopted (+3), merged (27.11.2017)
• https://git.orfeo-toolbox.org/otb.git/shortlog/refs/heads/ossimplugins_headers

Summary

This is a small RFC that installs ossimSarSensorModel headers (and related headers) so that the sensor model can be used and derived from an installed otb. New installed headers are installed in include/OTB-x.y/ossim/

Rationale

OssimPlugins is a kind of no man's land: it is not really in otb, nor in ossim. Therefore, in OTB we do not expose the headers to the users, and in ossim neither. This is ok for most of the ossimPlugins code, but the ossimSarSensorModel is a fully fonctioning SAR sensor model that can be used as is. As such it is interesting that its headers (and other related headers in ossimPlugins) are made available in OTB install include dir.

Implementation details

Classes and files

Following files were moved to Modules/ThirdParty/OssimPlugins/include/ossim :

ossimKeyWordListUtilities.h
ossimOperatorUtilities.h
ossimRangeUtilities.h
ossimSarSensorModel.h
ossimSarSensorModelPathsAndKeys.h
ossimStringUtilities.h
ossimTimeUtilities.h
ossimTraceHelpers.h
ossimXmlTools.h
ossimPluginConstants.h

Include paths have been fixed in Modules/ThirdParty/OssimPlugins/src/ and in Modules/adapters/OSSIMAdapters/.

Additional notes

I do not know what is the impact on debian packaging. We are installing other headers as well (such as SPTW), and those headers are not available in OSSIM, so I guess this is ok.